Skip to content

Change InstallParentPath to InstallPath#46

Merged
tigattack merged 3 commits intodevfrom
InstallParentPath-fix
Jun 26, 2022
Merged

Change InstallParentPath to InstallPath#46
tigattack merged 3 commits intodevfrom
InstallParentPath-fix

Conversation

@Philenst
Copy link
Contributor

Not sure why we use InstallParentPath in one file but InstallPath in the rest of the code, changed it to match, also should fix #45

@Philenst Philenst self-assigned this Jun 26, 2022
@tigattack
Copy link
Owner

Usage of InstallPath is counter-intuitive as that path is not actually the install path; it is, as the more commonly used InstallParentPath implies, the parent path of the install path. Further relocation of source files by the installer would need to be carried out for the parameter name InstallPath to be correct.

The Veeam configuration deployment script is the one which should be changed.

@Philenst
Copy link
Contributor Author

Good enough reason for me, reverted Installer change and fixed it in DeployVeeamConfiguration.

@Philenst Philenst requested a review from tigattack June 26, 2022 17:54
Copy link
Owner

@tigattack tigattack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phil.

@tigattack tigattack merged commit 461d11d into dev Jun 26, 2022
@tigattack tigattack deleted the InstallParentPath-fix branch June 26, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants