Skip to content

Conversation

@rmglennon
Copy link
Member

Do not merge yet!

Part of mapzen/documentation#310

This updates the API key placeholder text, some broken links (attribution.md was removed from published docs, so this hard-codes to the GitHub file), and some general style changes I happened to notice.

@rmglennon rmglennon changed the title Update API key placeholders, broken links, style Do not merge yet - Update API key placeholders, broken links, style Jun 19, 2017
@rmglennon rmglennon changed the title Do not merge yet - Update API key placeholders, broken links, style Update API key placeholders, broken links, style Jun 26, 2017
@rmglennon
Copy link
Member Author

This is ready for review and merge now. Testing looks OK for this section.

If you want to preview, you can go to https://dev.mapzen.com/documentation/vector-tiles/use-service/

When signed in, the placeholder text swaps to the first of your API keys. If you are not signed in or have no API keys, you still see your-mapzen-api-key.

Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nvkelso
Copy link
Member

nvkelso commented Jun 26, 2017

CircleCI is unhappy because Rhonda's fork doesn't have Matt's recent test changes (which fix the errors). She didn't change any code, so merging this.

@nvkelso nvkelso merged commit 139a6bd into tilezen:master Jun 26, 2017
@nvkelso nvkelso removed the in review label Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants