Add sort keys for "natural" landuse kinds#1720
Conversation
Insert `natural_wood`, `natural_forest` and `natural_park` into the middle of the sort ranking, bumping up all the values above them.
|
Please update for the following issues, too:
|
|
Added all those others - except for |
|
Ooops, yes those should also be landuse polygons. Good catch! |
| @@ -1,16 +1,16 @@ | |||
| kind,boundary,sort_rank | |||
| river,,201 | |||
There was a problem hiding this comment.
It means boundary is not set. The empty match in river,,201 translates to kind == 'river' and boundary == '', which never matched (boundary is either None or True), so all water features were getting a sort_rank of 200.
spreadsheets/sort_rank/landuse.csv
Outdated
| quay,*,65 | ||
| wharf,*,65 | ||
| port_terminal,*,64 | ||
| ferry_terminal,*,64 |
There was a problem hiding this comment.
Can't share sort values otherwise it creates flickr no Tangram ES... so this and quay and possibly others need to offset away from each other.
There was a problem hiding this comment.
I've re-arranged them in ffe23bd to make them unique. Also added a test, so that we'll get a test failure if a duplicate is added in future.
spreadsheets/sort_rank/landuse.csv
Outdated
| @@ -1,4 +1,5 @@ | |||
| kind,geometrytype,sort_rank | |||
| embankment,*,274 | |||
There was a problem hiding this comment.
Seems like this should go below power_line, more just under fence?
nvkelso
left a comment
nvkelso
left a comment
There was a problem hiding this comment.
Add 2 key-value pairs, spread the values for a few other keys (no dups values!)
…ly included only as POIs. Ensure landuse sort ranks are unique, and add test for that to maintain that requirement. Adjust tests where sort ranks have changed.
|
The following two kind values are new to the landuse layer and need to be documented:
|
2 participants
Insert
natural_wood,natural_forestandnatural_parkinto the middle of the sort ranking, bumping up all the values above them.Connects to #1096.
16 total new: