Recast Australia suburbs to towns #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
nvkelso
reviewed
Apr 22, 2022
| bbox | ||
| where st_within(way, bbox.geom)), | ||
|
|
||
| trim_major_cities as |
Member
There was a problem hiding this comment.
Explain that these 5 big labels are already in OSM are place=city, so we're trimming so we don't end up with duplicate place=town labels on the map.
nvkelso
reviewed
Apr 22, 2022
| @@ -0,0 +1,31 @@ | |||
| -- Suburbs in Australia are treated more like cities, so this recasts them to place=town | |||
|
|
|||
| with bbox as | |||
Member
There was a problem hiding this comment.
Nit: This looks not like a box to me... maybe say bounds instead of bbox?
Here and elsewhere...
added 2 commits
April 22, 2022 12:24
…ds' into junderwood/australia_neighborhoods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes place=suburb features within an Australian polygon into place=town to allow rendering.