Conversation
This was referenced May 2, 2024
Merged
Closed
gchtr
reviewed
May 14, 2024
gchtr
reviewed
May 14, 2024
gchtr
reviewed
May 14, 2024
gchtr
reviewed
May 14, 2024
gchtr
reviewed
May 14, 2024
gchtr
reviewed
May 14, 2024
gchtr
reviewed
May 14, 2024
gchtr
requested changes
May 14, 2024
Member
gchtr
left a comment
There was a problem hiding this comment.
Thanks for these improvements and moving PHP files more towards our Timber standard.
I found some things to look at and I added separate comments for those.
Merged
Member
Author
|
@gchtr , I went over all your requests. As mentioned, I would like to discuss how the starter theme should look like but all other items are done! |
gchtr
approved these changes
May 21, 2024
Member
|
@Levdbas Thanks for the updates! This looks good to me. Hit me up with anything you want to discuss :): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first changes in a larger set of changes that I am going to propose.
Related:
Issue
Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.
Solution
This particular PR focusses on overhauling the PHP files to:
Impact
A better, less confusing, start with templating in Timber.
Usage Changes
Code is now namespaced, so people will have to add filters/actions with a namespace reference as well. In a next PR I will also solely focus on the starttheme class.
Considerations
This is not adhering to any code style yet, I would like to introduce that soon as well and thus lint the whole codebase.
Testing
I might try to add some overall tests in the upcoming few PR's