Repository navigation
fix(api): refuse file:// feeds outside the allowed paths - #32
Merged
Merged
Conversation
_async_read_file read any file:// path the host user could read. It now asks hass.config.is_allowed_path() first and raises FeedparserApiError with a hint to allowlist_external_dirs, so only the config directory and explicitly allowed folders can be used as a feed source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_async_read_file read any file:// path the host user could read. It now asks
hass.config.is_allowed_path() first and raises FeedparserApiError with a hint
to allowlist_external_dirs, so only the config directory and explicitly
allowed folders can be used as a feed source.
Tests
New test test_local_feed_outside_allowed_dirs_is_refused (fails without the fix). pytest 266 passed locally (socket-bound HTTP tests excluded as on master). black clean.
No Docker or e2e run for this change. Board card c015.