Repository navigation
fix(parser): warn once per feed about empty feeds and bad dates - #33
Merged
Merged
Conversation
"No entries found" and "Unable to parse date" were logged as warnings on every poll, filling the log with the same line. The first occurrence per feed is still a warning, repeats go to debug, and an empty feed warns again after it had entries in between.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"No entries found" and "Unable to parse date" were logged as warnings on every
poll, filling the log with the same line. The first occurrence per feed is still
a warning, repeats go to debug, and an empty feed warns again after it had
entries in between.
Tests
New tests test_a_repeated_date_problem_is_only_warned_about_once and test_no_entries_is_only_warned_about_once_until_entries_return (both fail without the fix). pytest 267 passed locally. black clean.
No Docker or e2e run for this change. Board card c016.