Repository navigation
perf(sensor): keep entries and channel out of the recorder - #34
Merged
Merged
Conversation
The sensor wrote its full entries and channel attributes, up to the recorder limit, to the history on every change. They are now listed in _unrecorded_attributes so the database stays small; the live state is unchanged and feed_url is still recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sensor wrote its full entries and channel attributes, up to the recorder
limit, to the history on every change. They are now listed in
_unrecorded_attributes so the database stays small; the live state is unchanged
and feed_url is still recorded.
Tests
New test test_entries_and_channel_stay_out_of_the_recorder. pytest 273 passed locally. black clean.
No Docker or e2e run for this change. Board card c086.