Repository navigation
fix(parser): resolve relative links in summary HTML - #44
Merged
Merged
Conversation
link and links[].href were joined with the feed URL, but href and src inside the summary/content/subtitle HTML stayed relative. In a dashboard they pointed at Home Assistant instead of the feed's host. The sanitiser now resolves them against the feed URL after the allow-list ran, so only URLs it let through are joined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relative
hrefandsrcvalues inside the summary, content and subtitle HTML stayed relative, so in a dashboard they pointed at Home Assistant. They are now resolved against the feed URL, likelinkandlinks[].hrefalready were (c013). Resolution runs after the HTML allow-list, sojavascript:and similar URLs are still removed and only allowed URLs are joined. Entries and channel are both covered.Tests
tests/test_parser.py(absolute-path, relative-path, absolute URL,img src,javascript:href).tests/test_api.py: 338 passed. black clean; ruff clean on the changed source files.tests/test_api.pyfails locally with "the test opens sockets" (mismatched local venv), so CI is the reference for it.Board card c133.