Esp32s3 i2c interface#5210
Conversation
|
Can you please add a smoketest for this in the similar fashion as the previous PRs @dimajolkin thank you! |
|
I can't find any I2C tests for the ESP32XX (except for the I2C target, because the Listen(..) method isn't implemented in the ESP32XX). Perhaps I can add the esp32s3 to the i2c target since it has two I2C... |
Sorry I should have been more specific. The Looking, I see we are only doing this on 2 boards at present. Oops! In any case, you can perhaps use it instead of adding another example. |
|
@deadprogram Maybe we should rename it to i2c-blink this blinkm? |
|
As I understand it, we can add the esp32s3 to the i2c-target tests, but this requires implementing slave mode. If you don't mind doing this in a separate MR, I think there's some work on that. It just needs to be tested. |
It is named this because of the https://thingm.com/products/blinkm |
Doing in a different PR seems quite fine to me. |
|
Thanks for working on this @dimajolkin and to @soypat for helping review. Now squash/merging. |
* esp32s3-i2c implement interface * esp32s3-i2c: disable m5stamp_c3 * added simple tests without Listen * replace smoke tests * esp32s3-i2c: fix allocation in tx
* esp32s3-i2c implement interface * esp32s3-i2c: disable m5stamp_c3 * added simple tests without Listen * replace smoke tests * esp32s3-i2c: fix allocation in tx
* esp32s3-i2c implement interface * esp32s3-i2c: disable m5stamp_c3 * added simple tests without Listen * replace smoke tests * esp32s3-i2c: fix allocation in tx
* esp32s3-i2c implement interface * esp32s3-i2c: disable m5stamp_c3 * added simple tests without Listen * replace smoke tests * esp32s3-i2c: fix allocation in tx
Was added for esp32s3 i2c interface full based in esp32c3
Tested on: esp32s3, esp32s3-wroom1, esp32c3..
For test using a co2 sensor & Tdeck keyboard