UEFI Target groundwork: runtime: extract Windows PE globals scan helper#5361
Open
sparques wants to merge 1 commit intotinygo-org:devfrom
Open
UEFI Target groundwork: runtime: extract Windows PE globals scan helper#5361sparques wants to merge 1 commit intotinygo-org:devfrom
sparques wants to merge 1 commit intotinygo-org:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am back with another attempt trying to get UEFI as a target.
Summary
This PR extracts the PE/COFF globals-scanning logic from src/runtime/os_windows.go into a separate helper file, src/runtime/os_windows_pe.go.
The extracted code includes:
Why
The Windows runtime currently embeds PE parsing details directly inside findGlobals. Pulling that logic into a dedicated helper makes the runtime code easier to follow and isolates the PE-specific implementation detail in one place. For supporting UEFI, the PE stuff is needed isolated from the rest of os_windows.go.
Behavior
This is intended to be a mechanical refactor only. There should be no functional change to Windows behavior.