Skip to content

Download correct geckdriver file on Apple Silicon#234

Merged
kapoorlakshya merged 1 commit into
titusfortner:mainfrom
stephannv:patch-1
Aug 9, 2022
Merged

Download correct geckdriver file on Apple Silicon#234
kapoorlakshya merged 1 commit into
titusfortner:mainfrom
stephannv:patch-1

Conversation

@stephannv

@stephannv stephannv commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Geckodriver splits its Mac OS files into 2 versions (macos.tar.gz and macos-aarch64.tar.gz), and webdrivers doesn't work properly if macos.tar.gz is used on Apple Sillicon platform.
Geckodriver releases: https://github.com/mozilla/geckodriver/releases

@kapoorlakshya

Copy link
Copy Markdown
Collaborator

@stephannv Thanks for your contribution! Can you please add a test for this and rebase on main? I just fixed two broken tests and CI checks should be green now.

@stephannv

Copy link
Copy Markdown
Contributor Author

Done @kapoorlakshya.

Geckodriver splits its Mac OS files into 2 versions (macos.tar.gz and macos-aarch64.tar.gz), and webdriver doesn't work properly if `macos.tar.gz` is used on Apple Sillicon platform.
Geckodriver releases: https://github.com/mozilla/geckodriver/releases
@stephannv

Copy link
Copy Markdown
Contributor Author

Specs fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants