Links in XML not properly encoded

[krzys-h]

I'm trying to alter a .gpx file which contains a link along the lines of:

<?xml version="1.0" encoding="UTF-8"?>
<gpx xmlns="http://www.topografix.com/GPX/1/1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd" version="1.1">
  <metadata>
    <link href="https://example.com/?this=is&amp;an=example">
      <text>some text</text>
    </link>
  </metadata>
</gpx>

After modifying the file using gpxpy and exporting with to_xml(), this turns into:

<?xml version="1.0" encoding="UTF-8"?>
<gpx xmlns="http://www.topografix.com/GPX/1/1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd" version="1.1">
  <metadata>
    <link href="https://example.com/?this=is&an=example">
      <text>some text</text>
    </link>
  </metadata>
</gpx>

which is not valid XML (as even the GitHub markdown highlighting shows) - unlike HTML5, you need to always encode the &. This causes the file to fail to import in gpxpod (and maybe other gpx viewers as well)

[Guillaume-Fgt]

Up.

Encountered the same problem today with a file generated by Brouter.

Before:
<link href="https://brouter.m11n.de/#map=16/48.6891/2.0214/standard&amp;lonlats=2.01505,48.690593;2.021533,48.686074">

After file modified by gpxpy:
<link href="https://brouter.m11n.de/#map=16/48.6891/2.0214/standard&lonlats=2.01505,48.690593;2.021533,48.686074">

If I try to reimport it in Brouter, I have this error:

Error loading tracks: GeoJSON has no valid layers.

If I remove the link tag, it works.

[hggh]

I fixed that with: #288