Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 85.86% 85.83% -0.04%
==========================================
Files 50 49 -1
Lines 2702 2696 -6
==========================================
- Hits 2320 2314 -6
Misses 382 382 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ashesh-0, in playing around with fluors in #18, I found an issue with the caching in bin_events. Namely, the generated bins do depend on
em_events, butem_eventsaren't a part of the cache key... so if you ever calculate bins for a given fluorophore & num-bins with a weird em_events, you never recover from it. For example, if you calculate an off-channel fluorophore (like mCherry detected in the EGFP channel... which will have nearly no events), then forever more you get weird bins for mCherry.I don't think it's a performance bottle neck yet, so this PR just removes the caching