Skip to content

Fix a case when the alias is not a proper sub path #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tleunen merged 2 commits into from
May 16, 2017
Merged

Fix a case when the alias is not a proper sub path #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aada32
Fix a case when the alias is not a proper sub path
fatfisz May 15, 2017
41d9744
Simplify the alias regular expression
fatfisz May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/normalizeOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function normalizeAlias(opts) {
opts.alias = aliasKeys.map(key => (
isRegExp(key) ?
getAliasPair(key, alias[key]) :
getAliasPair(`^${key}((?:/|).*)`, `${alias[key]}\\1`)
getAliasPair(`^${key}(/.*|)$`, `${alias[key]}\\1`)
));
} else {
opts.alias = [];
Expand Down
16 changes: 16 additions & 0 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,14 @@ describe('module-resolver', () => {
);
});

it('should not alias if there is no proper sub path', () => {
testWithImport(
'components_dummy',
'components_dummy',
aliasTransformerOpts,
);
});

it('should alias the sub file path', () => {
testWithImport(
'test/tools',
Expand All @@ -292,6 +300,14 @@ describe('module-resolver', () => {
);
});

it('should not alias if there is no proper sub path', () => {
testWithImport(
'awesome/componentss',
'awesome/componentss',
aliasTransformerOpts,
);
});

it('should alias the sub file path', () => {
testWithImport(
'awesome/components/Header',
Expand Down