Skip to content

Conversation

@lBilali
Copy link
Contributor

@lBilali lBilali commented Nov 13, 2025

DATEDIFF_BIG is implemented same way as COUNT_BIG is implemented

Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@georgesittas georgesittas changed the title feat(tsql): add DATEDIFF_BIG feat(tsql)!: add DATEDIFF_BIG Nov 13, 2025
@georgesittas georgesittas merged commit 1609a18 into tobymao:main Nov 13, 2025
7 checks passed
georgesittas pushed a commit that referenced this pull request Nov 13, 2025
georgesittas added a commit that referenced this pull request Nov 18, 2025
* Feat(tsql)!: support `DATEDIFF_BIG` (#6323)

Co-authored-by: Lulzim Bilali <[email protected]>

* DATEPART and FORMAT are decoupled

DATEPART works for all of tsql datepart options and abbreviations

* move _build_datepart inside the generator and use extract_sql

* move DATE_PART_UNMAPPING to global scope

* remove empty lines

* remove casting and add tests for all abbreviations

* add back casting to datetime2

* Revert "add back casting to datetime2"

This reverts commit 712f2a8.

* Remove invalid test

---------

Co-authored-by: Lulzim Bilali <[email protected]>
Co-authored-by: Jo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants