Skip to content

fix(tsql)!: handle all datepart alternatives #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 10 commits into from
Nov 18, 2025
Merged

fix(tsql)!: handle all datepart alternatives #6324

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1609a18
Feat(tsql)!: support `DATEDIFF_BIG` (#6323)
lBilali Nov 13, 2025
7a6df9e
DATEPART and FORMAT are decoupled
Nov 13, 2025
d6c1a5c
Merge remote-tracking branch 'upstream/main' into datepart_new
Nov 13, 2025
6619738
move _build_datepart inside the generator and use extract_sql
Nov 17, 2025
976ca94
move DATE_PART_UNMAPPING to global scope
Nov 17, 2025
e30cbf6
remove empty lines
Nov 17, 2025
bf6e5dc
remove casting and add tests for all abbreviations
Nov 17, 2025
712f2a8
add back casting to datetime2
Nov 17, 2025
b8cd9cd
Revert "add back casting to datetime2"
Nov 18, 2025
2d12b96
Remove invalid test
georgesittas Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 44 additions & 10 deletions sqlglot/dialects/tsql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
strposition_sql,
timestrtotime_sql,
trim_sql,
map_date_part,
)
from sqlglot.helper import seq_get
from sqlglot.parser import build_coalesce
Expand Down Expand Up @@ -201,20 +202,12 @@ def _build_hashbytes(args: t.List) -> exp.Expression:
return exp.func("HASHBYTES", *args)


DATEPART_ONLY_FORMATS = {"DW", "WK", "HOUR", "QUARTER", "ISO_WEEK"}


def _format_sql(self: TSQL.Generator, expression: exp.NumberToStr | exp.TimeToStr) -> str:
fmt = expression.args["format"]

if not isinstance(expression, exp.NumberToStr):
if fmt.is_string:
mapped_fmt = format_time(fmt.name, TSQL.INVERSE_TIME_MAPPING)

name = (mapped_fmt or "").upper()
if name in DATEPART_ONLY_FORMATS:
return self.func("DATEPART", name, expression.this)

fmt_sql = self.sql(exp.Literal.string(mapped_fmt))
else:
fmt_sql = self.format_time(expression) or self.sql(fmt)
Expand All @@ -224,6 +217,19 @@ def _format_sql(self: TSQL.Generator, expression: exp.NumberToStr | exp.TimeToSt
return self.func("FORMAT", expression.this, fmt_sql, expression.args.get("culture"))


def _build_datepart(self: TSQL.Generator, expression: exp.Extract) -> str:
DATE_PART_UNMAPPING = {
"WEEKISO": "ISO_WEEK",
"DAYOFWEEK": "WEEKDAY",
"TIMEZONE_MINUTE": "TZOFFSET",
}
Comment thread
georgesittas marked this conversation as resolved.
Outdated

part = expression.this
name = DATE_PART_UNMAPPING.get(part.name.upper()) or part

return self.func("DATEPART", name, expression.expression)


def _string_agg_sql(self: TSQL.Generator, expression: exp.GroupConcat) -> str:
this = expression.this
distinct = expression.find(exp.Distinct)
Expand Down Expand Up @@ -418,6 +424,22 @@ class TSQL(Dialect):

EXPRESSION_METADATA = EXPRESSION_METADATA.copy()

DATE_PART_MAPPING = {
**Dialect.DATE_PART_MAPPING,
"QQ": "QUARTER",
"M": "MONTH",
"Y": "DAYOFYEAR",
"WW": "WEEK",
"N": "MINUTE",
"SS": "SECOND",
"MCS": "MICROSECOND",
"TZOFFSET": "TIMEZONE_MINUTE",
"TZ": "TIMEZONE_MINUTE",
Comment thread
georgesittas marked this conversation as resolved.
"ISO_WEEK": "WEEKISO",
"ISOWK": "WEEKISO",
"ISOWW": "WEEKISO",
}

TIME_MAPPING = {
"year": "%Y",
"dayofyear": "%j",
Expand Down Expand Up @@ -604,7 +626,6 @@ class Parser(parser.Parser):
exp.DateDiff, unit_mapping=DATE_DELTA_INTERVAL, big_int=True
),
"DATENAME": _build_formatted_time(exp.TimeToStr, full_format_mapping=True),
"DATEPART": _build_formatted_time(exp.TimeToStr),
"DATETIMEFROMPARTS": _build_datetimefromparts,
"EOMONTH": _build_eomonth,
"FORMAT": _build_format,
Expand Down Expand Up @@ -670,6 +691,7 @@ class Parser(parser.Parser):
order=self._parse_order(),
null_handling=self._parse_on_handling("NULL", "NULL", "ABSENT"),
),
"DATEPART": lambda self: self._parse_datepart(),
}

# The DCOLON (::) operator serves as a scope resolution (exp.ScopeResolution) operator in T-SQL
Expand All @@ -688,6 +710,18 @@ class Parser(parser.Parser):
"ts": exp.Timestamp,
}

def _parse_datepart(self) -> exp.Expression:
Comment thread
lBilali marked this conversation as resolved.
Outdated
this = self._parse_var()
expression = self._match(TokenType.COMMA) and self._parse_bitwise()
name = map_date_part(this, self.dialect)
type_name = "TIMESTAMP"

if isinstance(name, exp.Expression) and name.name == "TIMEZONE_MINUTE":
type_name = "TIMESTAMPTZ"
Comment thread
georgesittas marked this conversation as resolved.
Outdated

expr = self.expression(exp.Cast, this=expression, to=exp.DataType.build(type_name))
return self.expression(exp.Extract, this=name, expression=expr)

def _parse_alter_table_set(self) -> exp.AlterSet:
return self._parse_wrapped(super()._parse_alter_table_set)

Expand Down Expand Up @@ -1044,7 +1078,7 @@ class Generator(generator.Generator):
exp.CurrentTimestamp: rename_func("GETDATE"),
exp.CurrentTimestampLTZ: rename_func("SYSDATETIMEOFFSET"),
exp.DateStrToDate: datestrtodate_sql,
exp.Extract: rename_func("DATEPART"),
exp.Extract: _build_datepart,
Comment thread
lBilali marked this conversation as resolved.
Outdated
exp.GeneratedAsIdentityColumnConstraint: generatedasidentitycolumnconstraint_sql,
exp.GroupConcat: _string_agg_sql,
exp.If: rename_func("IIF"),
Expand Down
37 changes: 20 additions & 17 deletions tests/dialects/test_tsql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,27 +1497,30 @@ def test_datepart(self):
)
self.validate_identity(
"DATEPART(YEAR, x)",
"FORMAT(CAST(x AS DATETIME2), 'yyyy')",
"DATEPART(YEAR, CAST(x AS DATETIME2))",
Comment thread
georgesittas marked this conversation as resolved.
Outdated
)
self.validate_identity(
"DATEPART(HOUR, date_and_time)",
"DATEPART(HOUR, CAST(date_and_time AS DATETIME2))",
)
self.validate_identity(
"DATEPART(WEEKDAY, date_and_time)",
"DATEPART(DW, CAST(date_and_time AS DATETIME2))",
"DATEPART(WEEKDAY, CAST(date_and_time AS DATETIME2))",
)
self.validate_identity(
"DATEPART(tz, date_and_time)",
"DATEPART(TZOFFSET, CAST(date_and_time AS DATETIMEOFFSET))",
Comment thread
georgesittas marked this conversation as resolved.
Outdated
)
self.validate_identity(
"DATEPART(DW, date_and_time)",
"DATEPART(DW, CAST(date_and_time AS DATETIME2))",
"DATEPART(WEEKDAY, CAST(date_and_time AS DATETIME2))",
)

self.validate_all(
"SELECT DATEPART(month,'1970-01-01')",
write={
"postgres": "SELECT TO_CHAR(CAST('1970-01-01' AS TIMESTAMP), 'MM')",
"spark": "SELECT DATE_FORMAT(CAST('1970-01-01' AS TIMESTAMP), 'MM')",
"tsql": "SELECT FORMAT(CAST('1970-01-01' AS DATETIME2), 'MM')",
"postgres": "SELECT EXTRACT(month FROM CAST('1970-01-01' AS TIMESTAMP))",
"spark": "SELECT EXTRACT(month FROM CAST('1970-01-01' AS TIMESTAMP))",
"tsql": "SELECT DATEPART(month, CAST('1970-01-01' AS DATETIME2))",
},
)
self.validate_all(
Expand All @@ -1526,9 +1529,9 @@ def test_datepart(self):
"postgres": "SELECT DATE_PART('YEAR', '2017-01-01'::DATE)",
},
write={
"postgres": "SELECT TO_CHAR(CAST(CAST('2017-01-01' AS DATE) AS TIMESTAMP), 'YYYY')",
"spark": "SELECT DATE_FORMAT(CAST(CAST('2017-01-01' AS DATE) AS TIMESTAMP), 'yyyy')",
"tsql": "SELECT FORMAT(CAST(CAST('2017-01-01' AS DATE) AS DATETIME2), 'yyyy')",
"postgres": "SELECT EXTRACT(YEAR FROM CAST(CAST('2017-01-01' AS DATE) AS TIMESTAMP))",
"spark": "SELECT EXTRACT(YEAR FROM CAST(CAST('2017-01-01' AS DATE) AS TIMESTAMP))",
"tsql": "SELECT DATEPART(YEAR, CAST(CAST('2017-01-01' AS DATE) AS DATETIME2))",
},
)
self.validate_all(
Expand All @@ -1537,9 +1540,9 @@ def test_datepart(self):
"postgres": "SELECT DATE_PART('month', '2017-03-01'::DATE)",
},
write={
"postgres": "SELECT TO_CHAR(CAST(CAST('2017-03-01' AS DATE) AS TIMESTAMP), 'MM')",
"spark": "SELECT DATE_FORMAT(CAST(CAST('2017-03-01' AS DATE) AS TIMESTAMP), 'MM')",
"tsql": "SELECT FORMAT(CAST(CAST('2017-03-01' AS DATE) AS DATETIME2), 'MM')",
"postgres": "SELECT EXTRACT(month FROM CAST(CAST('2017-03-01' AS DATE) AS TIMESTAMP))",
"spark": "SELECT EXTRACT(month FROM CAST(CAST('2017-03-01' AS DATE) AS TIMESTAMP))",
"tsql": "SELECT DATEPART(month, CAST(CAST('2017-03-01' AS DATE) AS DATETIME2))",
},
)
self.validate_all(
Expand All @@ -1548,16 +1551,16 @@ def test_datepart(self):
"postgres": "SELECT DATE_PART('day', '2017-01-02'::DATE)",
},
write={
"postgres": "SELECT TO_CHAR(CAST(CAST('2017-01-02' AS DATE) AS TIMESTAMP), 'DD')",
"spark": "SELECT DATE_FORMAT(CAST(CAST('2017-01-02' AS DATE) AS TIMESTAMP), 'dd')",
"tsql": "SELECT FORMAT(CAST(CAST('2017-01-02' AS DATE) AS DATETIME2), 'dd')",
"postgres": "SELECT EXTRACT(day FROM CAST(CAST('2017-01-02' AS DATE) AS TIMESTAMP))",
"spark": "SELECT EXTRACT(day FROM CAST(CAST('2017-01-02' AS DATE) AS TIMESTAMP))",
"tsql": "SELECT DATEPART(day, CAST(CAST('2017-01-02' AS DATE) AS DATETIME2))",
},
)

for fmt in ("WEEK", "WW", "WK"):
self.validate_identity(
f"SELECT DATEPART({fmt}, '2024-11-21')",
"SELECT DATEPART(WK, CAST('2024-11-21' AS DATETIME2))",
"SELECT DATEPART(WEEK, CAST('2024-11-21' AS DATETIME2))",
)

for fmt in ("ISOWK", "ISOWW", "ISO_WEEK"):
Expand Down