ci: enable clippy lints by taiki-e · Pull Request #1335 · tokio-rs/tokio

taiki-e · 2019-07-21T00:05:25Z

Related: #1334

~~Those that may change the public API and~~ Those that may change the implementation significantly is allowed (~~trivially_copy_pass_by_ref~~, mut_from_ref, etc.).

Refs: https://rust-lang.github.io/rust-clippy/master/index.html (list of clippy lints)

cc @carllerche

* clippy::mut_from_ref * clippy::map_clone * clippy::should_implement_trait * clippy::transmute_ptr_to_ptr * clippy::trivially_copy_pass_by_ref * clippy::type_complexity * clippy::module_inception * clippy::wrong_self_convention * clippy::mutex_atomic

* clippy::needless_lifetimes * clippy::unnecessary_mut_passed * clippy::assign_op_pattern * clippy::while_let_on_iterator * clippy::let_and_return * clippy::needless_range_loop * clippy::len_zero * clippy::single_match * clippy::match_bool * clippy::redundant_pattern_matching * clippy::needless_return * clippy::collapsible_if * clippy::let_unit_value * clippy::unit_arg * clippy::duration_subsec * clippy::redundant_closure * clippy::new_without_default * clippy::option_map_unit_fn * clippy::cast_lossless

This reverts commit 9761168. False positive has been fixed in newer nightly.

taiki-e · 2019-07-21T06:33:27Z

Seems rustfmt somehow checks the crates in /usr/local/cargo/registry/src/git.832008.xyz-1ecc6299db9ec823/, but I'm not sure about how to fix or reproduce it:
https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=1569&view=logs&jobId=f14073de-e1a4-5ba6-5dc1-4c667fb92951

carllerche · 2019-07-21T17:59:57Z

@taiki-e that is very odd... adding clippy does this?

carllerche · 2019-07-21T18:00:20Z

Does this happen on master?

taiki-e · 2019-07-21T18:49:05Z

Currently, I think eb4d80a (bump rustc version to nightly-2019-07-19) is related because rustfmt error did not occur in 9761168.

However, no problems occurred in locally with either branch.

taiki-e · 2019-07-21T18:51:27Z

Does this happen on master?

However, no problems occurred in locally with either branch.

I opened #1338 to check it.

carllerche

Thanks! Looking good 👍

I added thoughts inline. Also, could we avoid file level allows in favor of adding them on the item? I'm not sure what they are referencing. thanks!

…WaiterNode>`

carllerche · 2019-07-22T17:10:47Z

    waker: Arc<ThreadWaker>,
 }

+#[allow(clippy::mutex_atomic)]


I recommended removing this lint: rust-lang/rust-clippy#4295

We probably should just disable this lint at the project level. This can happen in this PR or follow up work.

Done in ae3bd60.

carllerche

Thanks 👍

I think most of the allow bits (that are not false positives) can be removed. That can happen here or later. I approved, so feel free to merge if you are happy.

taiki-e · 2019-07-24T07:37:20Z

-    pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> {
-        self.io.get_ref().leave_multicast_v4(multiaddr, interface)
+    pub fn leave_multicast_v4(&self, multiaddr: Ipv4Addr, interface: Ipv4Addr) -> io::Result<()> {
+        self.io.get_ref().leave_multicast_v4(&multiaddr, &interface)


mio 0.7 changed this to pass by value 👍 : tokio-rs/mio#894

taiki-e · 2019-07-24T07:58:51Z

@carllerche I have removed all of allow(clippy::..) that are not false positives. (They were much easier than I had imagined. I thought it would cause other warnings but it did not happen.)

taiki-e · 2019-07-25T18:17:10Z

Resolved a conflict, will merge once CI passed.

taiki-e added 3 commits July 21, 2019 09:00

ci: enable clippy lints

d464253

Allow some clippy warnings

cd543bf

* clippy::mut_from_ref * clippy::map_clone * clippy::should_implement_trait * clippy::transmute_ptr_to_ptr * clippy::trivially_copy_pass_by_ref * clippy::type_complexity * clippy::module_inception * clippy::wrong_self_convention * clippy::mutex_atomic

taiki-e mentioned this pull request Jul 21, 2019

chore: remove redundant field names in struct literals #1334

Merged

cargo fmt --all

c20c23d

taiki-e commented Jul 21, 2019

View reviewed changes

Comment thread tokio-threadpool/src/pool/backup.rs

taiki-e added 4 commits July 21, 2019 09:24

Remove default impls to private type added by 0cdc174

063c4d2

Allow clippy::cast_ptr_alignment warnings

9761168

Revert "Allow clippy::cast_ptr_alignment warnings"

85addd5

This reverts commit 9761168. False positive has been fixed in newer nightly.

Bump to newer nightly

eb4d80a

taiki-e closed this Jul 21, 2019

taiki-e reopened this Jul 21, 2019

taiki-e mentioned this pull request Jul 21, 2019

chore: bump to newer nightly #1338

Merged

taiki-e added 2 commits July 22, 2019 05:19

Use nightly-2019-07-17

4191092

Merge branch 'master' into ci-clippy

2b9ab4f

taiki-e requested a review from carllerche July 21, 2019 21:45

carllerche requested changes Jul 21, 2019

View reviewed changes

taiki-e added 8 commits July 22, 2019 13:24

Move allow(clippy::trivially_copy_pass_by_ref) from crate to items

f549d8b

Move allow(clippy::mutex_atomic) from module to items

cf79f7c

timer: move contents of clock/clock.rs into clock/mod.rs

f210250

sync: change the argument of WaiterNode::into_non_null to `self: Arc<…

d63fc9c

…WaiterNode>`

timer: change Entry::time_mut to unsafe fn

b694a3b

allow clippy::mut_from_ref and clippy::wrong_self_convention

b5c8e69

threadpool: fix clippy::type_complexity

56a7c33

remove unnecessary code

edca75d

add a comment

2baee47

carllerche mentioned this pull request Jul 22, 2019

chore: audit deny lints in crates #1083

Closed

carllerche reviewed Jul 22, 2019

View reviewed changes

Comment thread tokio-reactor/src/lib.rs Outdated

carllerche reviewed Jul 22, 2019

View reviewed changes

Comment thread tokio-sync/src/oneshot.rs Outdated

carllerche reviewed Jul 22, 2019

View reviewed changes

carllerche approved these changes Jul 22, 2019

View reviewed changes

taiki-e added 3 commits July 24, 2019 16:04

allow clippy::mutex_atomic at the project level

ae3bd60

Merge branch 'master' into ci-clippy

3a9fa19

fix most of clippy::trivially_copy_pass_by_ref

614aa54

taiki-e commented Jul 24, 2019

View reviewed changes

fix more

2a05364

Merge branch 'master' into ci-clippy

9c5cd86

Merge branch 'master' into ci-clippy

2035f15

carllerche approved these changes Jul 25, 2019

View reviewed changes

taiki-e merged commit fe021e6 into tokio-rs:master Jul 25, 2019

taiki-e deleted the ci-clippy branch July 25, 2019 18:47

This was referenced Aug 3, 2019

cargo fmt --all -- --check issues error for crate that is not part of either the workspace or the path dependencies. rust-lang/rustfmt#3725

Closed

chore: bump to newer nightly #1384

Closed

Uh oh!

Uh oh!

Conversation

taiki-e commented Jul 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

taiki-e commented Jul 21, 2019

Uh oh!

carllerche commented Jul 21, 2019

Uh oh!

carllerche commented Jul 21, 2019

Uh oh!

taiki-e commented Jul 21, 2019

Uh oh!

taiki-e commented Jul 21, 2019

Uh oh!

carllerche left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carllerche Jul 22, 2019

Choose a reason for hiding this comment

Uh oh!

carllerche Jul 22, 2019

Choose a reason for hiding this comment

Uh oh!

taiki-e Jul 24, 2019

Choose a reason for hiding this comment

Uh oh!

carllerche left a comment

Choose a reason for hiding this comment

Uh oh!

taiki-e Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taiki-e commented Jul 24, 2019

Uh oh!

taiki-e commented Jul 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

taiki-e commented Jul 21, 2019 •

edited

Loading

taiki-e Jul 24, 2019 •

edited

Loading