Conversation
6a7cf31 to
3a81990
Compare
|
@TakuyaKurimoto Thanks for the PR! unfortunately I'm not familiar with the runtime mappings features, let me learn it and get back to you. |
|
OK! |
|
@konalegi |
|
@TakuyaKurimoto Sorry, was extremely busy. Is this PR still relevant? |
|
@konalegi |
|
Cool, can you rebase and push latest changes so I can run CI? |
3a81990 to
dd04e71
Compare
|
@konalegi |
|
Everything is passing, let me get familiar with the topic, and I'll merge it. |
|
Thank you! |
|
@TakuyaKurimoto looks good 👍 Although could you please add a couple of lines into documentation about this feature, no extensive doc is needed, just an example + reference to elastic doc, so people know that this feature exists. |
|
@konalegi |
|
@TakuyaKurimoto Actually I'm about README.md |
693f689 to
ef5d800
Compare
|
@konalegi |
|
Master has been updated with CI fixes and compatibility changes (#998) — we now target Ruby 3.2+ and Rails 7.2+. Could you rebase this PR on top of master so CI can run properly? Thanks! |
|
Nice addition — Could you rebase onto current master? The branch is quite old (2+ years) and will need updating. Also please add a changelog entry. |
ef5d800 to
ce27b79
Compare
|
@bbatsov |
There was a problem hiding this comment.
Thanks for the PR! The implementation is clean and follows existing patterns well. A couple of things to address:
-
Wrong
@seereference — Inlib/chewy/search/request.rb, the newruntime_mappingsdocblock has@see Chewy::Search::Parameters::ScriptFieldsbut it should be@see Chewy::Search::Parameters::RuntimeMappings. -
Inconsistent hash syntax in the
@example— The example mixes symbol rockets (:script=>) with modern hash syntax (type:). Would be cleaner to pick one style consistently.
Also, the branch is quite far behind master at this point — please rebase on top of the current master (and address the changelog conflict).
ce27b79 to
b6f59a6
Compare
|
@bbatsov |
Hello.
One time I wanted to use runtime_mappings, but in chewy I had to write the following code because chewy does not support runtime_mappings .
This is a bit inconvenient, so I was wondering if you could support runtime_mappings in chewy as well?
If this code is merged, it will be possible to do something like the code below
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).