Add context option to .import for passing custom data #996
Open
dimitrikochnev wants to merge 1 commit intotoptal:masterfrom
Open
Add context option to .import for passing custom data #996dimitrikochnev wants to merge 1 commit intotoptal:masterfrom
dimitrikochnev wants to merge 1 commit intotoptal:masterfrom
Conversation
Member
|
Master has been updated with CI fixes and compatibility changes (#998) — we now target Ruby 3.2+ and Rails 7.2+. Could you rebase this PR on top of master so CI can run properly? Thanks! |
Author
|
Let me find there is it :-) |
de2c8b4 to
dc8e025
Compare
Author
|
@bbatsov yep, done |
Member
|
Interesting feature. The design is clean — flowing A couple of questions:
Will review the code in detail after rebase. |
dc8e025 to
c33f5de
Compare
Author
|
Done. I will give you a practical example storing video embeddings: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When importing objects, the data needed for indexing (e.g., embeddings, computed attributes) is often already available in memory at the call site. However, currently, crutch blocks are forced to re-fetch (even with direct_import) this data from the database, resulting in redundant queries and wasted resources.
There is currently no mechanism to pass this pre-computed data from the import call site down into crutch blocks or field value procs.
This design aligns with established patterns in the Ruby ecosystem, such as graphql-ruby and ActiveModelSerializers. In those libraries, a context object is similarly passed through the resolution or serialization stack to share request-level state (like current user, auth tokens, or pre-loaded data) without relying on global state.
Solution
Add an optional
context:keyword argument toimport/import!that flows through the entire indexing pipeline. Context is an arbitrary hash, defaulting to{}.Context in crutch blocks (2nd argument)
Context in field value procs (3rd argument)
Both are fully backward-compatible — existing 1-arg crutch blocks and 1-2 arg field procs continue to work unchanged via arity-based dispatch.