Merged
Conversation
* TH_ALLOCATOR_MAPPED_FROMFD uses an existing file descriptor for mapping (and steals it) * TH_ALLOCATOR_MAPPED_KEEPFD doesn't close the file descriptor until the mapping is freed * TH_ALLOCATOR_MAPPED_UNLINK unlinks the file immediately after mapping it to memory Also, now it's using fstat to check the file size (instead of lseek, which alters the fd state).
Member
|
cc: @akfidjeland @timharley wrt the change from lseek to fstat. It's harmless, but want to keep you in the loop. |
Contributor
|
Thanks @soumith |
Member
|
Thanks @apaszke ! |
|
I have problem with THAllocator.c line 262 gives me |
Member
|
yes, indeed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TH_ALLOCATOR_MAPPED_FROMFDuses an existing file descriptor formapping (and steals it)
TH_ALLOCATOR_MAPPED_KEEPFDdoesn't close the file descriptoruntil the mapping is freed
TH_ALLOCATOR_MAPPED_UNLINKunlinks the file immediately aftermapping it to memory
Also, now it's using
fstatto check the file size (instead oflseek, which alters the fd state).