fix: added int parameter to termhandler() function#81
Open
alanvespasian wants to merge 1 commit intotorrinfail:masterfrom
Open
fix: added int parameter to termhandler() function#81alanvespasian wants to merge 1 commit intotorrinfail:masterfrom
alanvespasian wants to merge 1 commit intotorrinfail:masterfrom
Conversation
termhandler is defined without any parameters, added int parameter to match expected signal handler signature
|
I had to make the changes in this pull request to dwmblocks.c in order to successfully make in vanilla Arch. Otherwise I got the error: dwmblocks.c:207:25: error: passing argument 2 of 'signal' from incompatible pointer type [-Wincompatible-pointer-types]. |
|
Same here. Was unable to build on vanilla arch, but these changes fixed it. thanks. |
|
Exact same error I was encountering, also on vanilla arch. Works after applying the changes. |
|
Yes, this fixed my build on Arch too. |
|
Same here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
termhandler is defined without any parameters, added int parameter to match expected signal handler signature
this fixes the compiler error:
dwmblocks.c:207:25: error: passing argument 2 of 'signal' from incompatible pointer type [-Wincompatible-pointer-types]