Skip to content

Conversation

@grigi
Copy link
Member

@grigi grigi commented Sep 22, 2019

Done:

  • Pulled the py.test changes from [WIP] New pooling for mysql and asynpg #141
  • Moved tests out of the library path.
  • Moved the of the dev-oriented requirements out to the tests folder.
  • Collapsed Travis/tox runs to do full test suite for each supported language
  • Do backup tests via green instead of py.test
  • Moved extra_requirements.txt to tests/
  • make ci now runs tests against ALL supported DB's
  • made py.test runs multi-process for a significant speedup (still slower than green, though)

This should do a few things:

  • Less CI runs on Travis should let it complete faster.
  • Cleaned up the root folder
  • Tests no longer in the library module path, so a little easier to keep separate.
  • Since coveralls broke in handling multiple test runs, at least now the coverage reported will be correct.
  • Default to py.test due to a bit more features (e.g. collect warnings, etc) Although performance is notably slower than green, it is still worth it for the extra flexibility.

@coveralls
Copy link

coveralls commented Sep 22, 2019

Pull Request Test Coverage Report for Build 787

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.4%) to 98.101%

Totals Coverage Status
Change from base Build 774: 2.4%
Covered Lines: 5704
Relevant Lines: 5768

💛 - Coveralls

@grigi grigi requested a review from abondar September 22, 2019 18:23
@grigi
Copy link
Member Author

grigi commented Sep 23, 2019

@abondar Please review. I took the relevant changes from your PR #141

@grigi grigi merged commit 41df828 into develop Sep 23, 2019
@grigi grigi deleted the pytest branch September 24, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants