Skip to content
This repository was archived by the owner on Dec 18, 2025. It is now read-only.

Comments

fix(@toss/use-query-param): add extenion .js to import next/router#469

Merged
raon0211 merged 1 commit intotoss:mainfrom
bae-sh:main
Jun 3, 2024
Merged

fix(@toss/use-query-param): add extenion .js to import next/router#469
raon0211 merged 1 commit intotoss:mainfrom
bae-sh:main

Conversation

@bae-sh
Copy link
Contributor

@bae-sh bae-sh commented Apr 25, 2024

Overview

스크린샷 2024-04-22 오후 10 43 25

When i tried to use @toss/use-funnel, i got a error Cannot find module next/router

I found that @toss/use-funnel depended on @toss/use-query-param and fixed it by adding the extension.

My Next version is v13 and i found a similar case that fixed this issue in @toss/use-funnel.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@vercel
Copy link

vercel bot commented Apr 25, 2024

@bae-sh is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@raon0211
Copy link
Collaborator

raon0211 commented Jun 3, 2024

Thanks!

@raon0211 raon0211 merged commit 97d371b into toss:main Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants