fix(dataset): Add versions to dataset metadata #3732
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to abb97ad in 12 seconds. Click for details.
- Reviewed
50lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_082CasF48srknYek
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
📝 WalkthroughWalkthroughAdded a new DatasetVersion model with publication metadata, made DatasetMetadata.name optional, and added an optional versions list to DatasetMetadata; a sample app file received a single commented line addition only. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>
e6b94ca to
01350f1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/sample-app/sample_app/dataset_example.py`:
- Around line 510-512: Remove the commented-out dead code by deleting the stray
"# main()" in the if __name__ == "__main__": block and ensure the script either
implements the promised behavior (use client.datasets.get_all() to print dataset
versions—update the main() function to call client.datasets.get_all() and print
each dataset/version) or update the PR description to remove that claim; modify
the main() function (and any dataset-related helper functions) to perform the
dataset-version printing if you choose to add the feature, otherwise just remove
the commented line and correct the PR text.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
packages/sample-app/sample_app/dataset_example.pypackages/traceloop-sdk/traceloop/sdk/datasets/model.py
feat(instrumentation): ...orfix(instrumentation): ....Important
Add versioning to dataset metadata and update example script to demonstrate version retrieval.
versionsfield toDatasetMetadatainmodel.pyto store dataset version history.dataset_example.pyto print dataset versions usingclient.datasets.get_all().DatasetVersionclass inmodel.pywith fieldsversion,published_by, andpublished_at.Traceloop.init()call indataset_example.pyto useendpoint_is_traceloop=True.This description was created by
for abb97ad. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
New Features
Chores