[dev] Removed unneeded FireAnim.as from some blob scripts#2460
Open
mugg91 wants to merge 4 commits intotranshumandesign:masterfrom
Open
[dev] Removed unneeded FireAnim.as from some blob scripts#2460mugg91 wants to merge 4 commits intotranshumandesign:masterfrom
mugg91 wants to merge 4 commits intotranshumandesign:masterfrom
Conversation
mugg91
changed the title
Vam-Jam
added
the
scope: Refactor (no functional change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
FireAnim.asfrom blob scripts that don't also haveIsFlammable.as.Those blob scripts are
Grain.cfg,Tunnel.cfg,Storage.cfg,Tunnel.cfg,StoneDoor.cfg,Hall.cfg,WarboatDoor.cfg.After the removal, shooting fire arrow at Grain will still cause a fire cross and set nearby things on fire.
Context
IsFlammablefrom Grain but didn't removeFireAnim.as.IsFlammable.asfrom Tunnel, Quarry and Storage, but didn't removeFireAnim.as.