Add richer Follower interface enabling clean shutdown & stats#544
Merged
AlCutter merged 7 commits intoMar 20, 2025
Merged
Conversation
AlCutter
force-pushed
the
migration_follower_waiting
branch
3 times, most recently
from
016fdf3 to
2758554
Compare
AlCutter
changed the title
AlCutter
changed the title
AlCutter
force-pushed
the
migration_follower_waiting
branch
from
2758554 to
7d6ff40
Compare
AlCutter
force-pushed
the
migration_follower_waiting
branch
4 times, most recently
from
467e97b to
5b914c1
Compare
mhutchinson
approved these changes
Mar 20, 2025
| o.followers = append(o.followers, func(ctx context.Context, lr LogReader) { | ||
| as.Populate(ctx, lr, o.bundleIDHasher) | ||
| }) | ||
| o.followers = append(o.followers, as.Follower(o.bundleIDHasher)) |
Contributor
There was a problem hiding this comment.
Can you add a comment to bundleIDHasher that this must always be immutable after struct initialization? An easy trap now would be to add a feature to allow that to become mutable, which would make this WithAntispam method behave differently depending on order of calls.
mhutchinson
approved these changes
Mar 20, 2025
mhutchinson
left a comment
mhutchinson
left a comment
Contributor
There was a problem hiding this comment.
Consider adding tests for this.
AlCutter
force-pushed
the
migration_follower_waiting
branch
from
5b914c1 to
86f7e78
Compare
AlCutter
force-pushed
the
migration_follower_waiting
branch
from
03b5d5a to
c3fa903
Compare
Collaborator
Author
Yup, I'll come back with a follow-up PR so as not to block this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines a
Followerinterface which enables Tessera to know when it's safe to exit, e.g. during migration, we need to potentially wait for the antispam index to be fully populated.Towards #436