Move witnessing fully into lifecycle layer#578
Merged
Conversation
AlCutter
force-pushed
the
witnessing_up_a_level
branch
from
4e72222 to
750cf64
Compare
mhutchinson
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates responsibility for dealing with getting checkpoints witnessed in the lifecycle layer, removing the need for storage implementations to be aware of it.
This is a continuation of the approach taken for creating checkpoints and signing them.
Down the line we may want to add an (optional) mechanism to thread custom
http.Clientsin, currently applications could achieve something similar by configuringhttp.DefaultClient.Fixes #516