Skip to content

chore(core): fix deprecation warning for input_flow.throw(...)#5067

Merged
romanz merged 1 commit intomainfrom
romanz/fix-throw
May 30, 2025
Merged

chore(core): fix deprecation warning for input_flow.throw(...)#5067
romanz merged 1 commit intomainfrom
romanz/fix-throw

Conversation

@romanz
Copy link
Copy Markdown
Contributor

@romanz romanz commented May 21, 2025

.../trezor-firmware/python/src/trezorlib/debuglink.py:1143: DeprecationWarning: the (type, exc, tb) signature of throw() is deprecated, use the single-arg signature instead.
    input_flow.throw(exc_type, value, traceback)

https://docs.python.org/3.9/reference/expressions.html#generator.throw

Python 3.8 is no longer maintained: https://peps.python.org/pep-0569/

@trezor-bot trezor-bot Bot added this to Firmware May 21, 2025
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware May 21, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3W1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz self-assigned this May 21, 2025
@romanz romanz added tests Automated integration tests python Pull requests that update Python code labels May 21, 2025
@romanz
Copy link
Copy Markdown
Contributor Author

romanz commented May 21, 2025

gen.throw(typ, val, tb) was deprecated in python/cpython#96428.

@romanz romanz requested a review from mmilata May 21, 2025 08:10
@romanz romanz marked this pull request as ready for review May 21, 2025 08:10
@romanz romanz requested a review from matejcik as a code owner May 21, 2025 08:10
@romanz romanz force-pushed the romanz/fix-throw branch from 03fb762 to 0553036 Compare May 30, 2025 15:56
@romanz romanz merged commit 1880630 into main May 30, 2025
106 checks passed
@romanz romanz deleted the romanz/fix-throw branch May 30, 2025 16:28
@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware May 30, 2025
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Firmware Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code tests Automated integration tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants