Skip to content

Update certs.yml - fixed not-after#50

Merged
trfore merged 1 commit intotrfore:mainfrom
datbilling:patch-1
Jul 28, 2025
Merged

Update certs.yml - fixed not-after#50
trfore merged 1 commit intotrfore:mainfrom
datbilling:patch-1

Conversation

@datbilling
Copy link
Contributor

The certificate request --not-after argument was set to --san

Description

This pull request fixes a bug in the certificate generation task where the --not-after argument was incorrectly passed as --san.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration

# Please provide example playbook or CLI command
- name: Request x509 Certificate
      role: trfore.smallstep.step_cert
      vars:
        step_cert_list:
          - name: "{{ hostname }}.{{ domain_suffix }}"
            subject: "{{ hostname }}.{{ domain_suffix }}"
            path: "/etc/step/certs/"
            san_0: "{{ hostvars[hostname].ansible_host }}"
            not_after: "2160h"  # 90 days
            provisioner: "acme"

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

The certificate request --not-after argument was set to --san
@datbilling datbilling requested a review from trfore as a code owner July 28, 2025 21:24
@trfore
Copy link
Owner

trfore commented Jul 28, 2025

Thanks good catch, I'll push this to galaxy later tonight along with an updated testing scenario to check for this and other vars.

@trfore trfore merged commit a4b3680 into trfore:main Jul 28, 2025
17 of 18 checks passed
@datbilling
Copy link
Contributor Author

Thanks good catch, I'll push this to galaxy later tonight along with an updated testing scenario to check for this and other vars.

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants