Open
Conversation
Replace derived PartialOrd (which conflicted with explicit Ord) with a manual PartialOrd impl that delegates to Ord, using f64::total_cmp. Update public API snapshot for the &Self -> &MatchPower sig change.
Rewrite bench files to drop the removed standalone Bencher parameter style in favour of closures passed directly to bench_function/ bench_with_input, which is the modern criterion API.
keith-hall
reviewed
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yaml-rust2from0.10.4to0.11.0(pulls inhashlink 0.11)fancy-regexfrom0.16.2to0.17.0pretty_assertionsfrom0.6to1.4.1(dev-dep, no code changes needed)criterionfrom0.3to0.8.2(dev-dep, rewrote bench files to use the modern closure-based API —Bencheras a standalone function parameter was removed in 0.4)clippy::derive_ord_xor_partial_ordlint onMatchPower: replacedderive(PartialOrd)+ explicitimpl Ordwith a manualPartialOrdthat delegates toOrdviaf64::total_cmp; updated public API snapshot accordinglyVerification
All of the following were run locally and passed:
cargo test— 129 tests passed (unit, integration, doc-tests, public API snapshot)cargo fmt --check— no issuescargo clippy— no warnings or errorscargo build --benches— clean buildcargo bench— all benchmarks completed successfullyBenchmark results (vs. previous baseline)
Improved:
highlight/"parser.rs"highlight/"scope.rs"load_and_highlight/"highlight_test.erb"load_and_highlight/"InspiredGitHub.tmTheme"add_from_folderparse/"scope.rs"Minor regression (within noise):
from_dump_fileAll other benchmarks showed no statistically significant change.