Skip to content

Conversation

@sloede
Copy link
Member

@sloede sloede commented Jun 22, 2023

Resolves #17.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@8078677). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage        ?   73.01%           
=======================================
  Files           ?        2           
  Lines           ?       63           
  Branches        ?        0           
=======================================
  Hits            ?       46           
  Misses          ?       17           
  Partials        ?        0           
Flag Coverage Δ
unittests 73.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sloede sloede marked this pull request as ready for review June 22, 2023 11:19
@sloede sloede requested a review from benegee June 22, 2023 11:19
@sloede
Copy link
Member Author

sloede commented Jun 22, 2023

It would be great if you could have a quick look @bgeihe such that you have an idea of what I changed and did here. Right now, we are only doing smoke tests, i.e., I am running the simple example and verify that it does not return with a non-zero exit code.

@sloede
Copy link
Member Author

sloede commented Jun 22, 2023

Oh, and coverage is only covering the non-Julia files at the moment, so this is something to be investigated in the future.

@benegee
Copy link
Collaborator

benegee commented Jun 22, 2023

Something great again!

Concerning the coding, I'm lost though.

@benegee benegee merged commit c628a4f into main Jun 22, 2023
@benegee benegee deleted the msl/add-first-tests branch June 22, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests to the repo

3 participants