First steps towards accessing Trixi data #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benegee
commented
Jul 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 69.89% 71.69% +1.80%
==========================================
Files 6 8 +2
Lines 186 265 +79
==========================================
+ Hits 130 190 +60
- Misses 56 75 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sloede
reviewed
Jul 5, 2023
sloede
requested changes
Jul 14, 2023
Member
sloede
left a comment
sloede
left a comment
There was a problem hiding this comment.
Overall looks quite nice to me! I've done a "somewhat" in-depth review, so there a lots of small details I noticed. But I'll leave it up to you if you want to merge this fast now and clean up later, or do it thoroughly right now.
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Member
|
In general I noticed that you do not seem to test the new controllers... are they even built in the tests? |
sloede
reviewed
Aug 6, 2023
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
benegee
commented
Aug 14, 2023
Member
sloede
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended for merging, rather for getting used to Trixi.