Simplify usage by allow to omit the JULIA_DEPOT_PATH #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@KerstinHartung This should also make it easier for MESSy users, since one cannot forget to set the depot path anymore if one sticks to the default values... |
benegee
previously approved these changes
Jul 7, 2023
Collaborator
benegee
left a comment
benegee
left a comment
There was a problem hiding this comment.
This a fantastic idea! I will definitely make using libtrixi more easy!
sloede
commented
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 74.43% 70.12% -4.32%
==========================================
Files 4 5 +1
Lines 133 164 +31
==========================================
+ Hits 99 115 +16
- Misses 34 49 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, one always had to start programs with
JULIA_DEPOT_PATH=path myprogwhen running a programmyprogthat links tolibtrixi. With this PR, settingJULIA_DEPOT_PATHbecomes unnecessary as long as the default depot location used by byutils/libtrixi-init-juliais left untouched.This should help to avoid user errors in case they forget to set the Julia depot path appropriately. If a
JULIA_DEPOT_PATHenvironment variable is set, it will honored, thus the user can still provide non-standard locations via the environment. Overriding the default is also possible by callingtrixi_initializewith a second, non-null argument.