Create library with PackageCompiler.jl #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Enthused that you already got that started! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 98.20% 98.05% -0.16%
==========================================
Files 13 13
Lines 557 565 +8
==========================================
+ Hits 547 554 +7
- Misses 10 11 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…trixi-framework/libtrixi into msl/create-library-with-packagecompiler
sloede
changed the title
Member
Author
|
The decrease in coverage is imho a false negative. Other than that, I think this PR is ready for review and merge. |
Co-authored-by: Benedict <[email protected]>
benegee
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played around with compiling libtrixi directly from the Julia sources (without having to use our C library layer). This is very much WIP and lots is missing, but I didn't want to lose the effort, so here we go...