-
Notifications
You must be signed in to change notification settings - Fork 2
Julia test for LibTrixi.jl #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 95.88% 96.54% +0.65%
==========================================
Files 8 12 +4
Lines 316 492 +176
==========================================
+ Hits 303 475 +172
- Misses 13 17 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Summary
|
Simple unit tests can help here.
You can just call them in unit tests and verify that they return pointers that are not null.
Too hard to test. Just ignore it.
Again, just ignore.
Can't really tell why, just keep digging I guess? |
|
Thanks for the hints! |
|
All addressed. Except |
sloede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already quite good - with the remaining convo resolved, this can be merged.
Nicely done, upping the test coverage of the LibTrixi.jl folder from 0% to 97%! 🙌
This reverts commit 780e322.
sloede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last suggestion, then this LGTM!
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
sloede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
Co-authored-by: Benedict <[email protected]>
Should at some point resolve #67