Skip to content

Conversation

@benegee
Copy link
Collaborator

@benegee benegee commented Aug 23, 2023

I would like to have simple_trixi_controller.jl installed as well (and get the instructions in README.md right). It is however not really bin/.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #84 (0ee0c09) into main (d0a08d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files           8        8           
  Lines         314      314           
=======================================
  Hits          242      242           
  Misses         72       72           
Flag Coverage Δ
unittests 77.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@benegee benegee requested a review from sloede August 23, 2023 14:18
@sloede sloede marked this pull request as ready for review August 23, 2023 14:27
@benegee benegee requested a review from sloede August 24, 2023 11:15
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloede sloede enabled auto-merge (squash) August 24, 2023 12:05
@sloede sloede merged commit e19b886 into main Aug 24, 2023
@sloede sloede deleted the update-julia-controller-example branch August 24, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants