Skip to content

Conversation

@sloede
Copy link
Member

@sloede sloede commented Aug 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b4f6dec) 98.20% compared to head (bcd3408) 98.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          12       12           
  Lines         500      500           
=======================================
  Hits          491      491           
  Misses          9        9           
Flag Coverage Δ
unittests 98.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede sloede closed this Aug 30, 2023
@sloede sloede reopened this Aug 30, 2023
@sloede
Copy link
Member Author

sloede commented Aug 30, 2023

It's a small improvement only, but it seems like precompilation is indeed only happening once anymore.

@sloede sloede marked this pull request as ready for review August 30, 2023 13:54
@sloede sloede requested a review from benegee August 30, 2023 13:54
@sloede sloede enabled auto-merge (squash) August 30, 2023 13:54
Copy link
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A truly heroic endeavor!

Too sad the gain does not feel larger (I have not checked).
I would have though so, because the runtime increased so much once I added the Julia tests.

@sloede sloede merged commit ff61aa6 into main Aug 30, 2023
@sloede sloede deleted the msl/speed-up-testing branch August 30, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants