Open
Conversation
Collaborator
|
TBH, I am not sure if this is a pressing concern. And without any benchmarks, it feels hard to justify. |
Author
|
Fair point! I wrote a quick script to run the dist step for all examples, and I see it takes mere milliseconds to complete as the files max out at a few hundred kilobytes. I can agree it's perhaps not worth justifying here. If a user is hashing many megabytes worth of files then the difference would be more notable, as rapidhash should be 5-10x faster on most platforms. Are larger builds or image assets occasionally hashed by users in the trunk dist step, in the same way they might be by static site generators? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Maintainer of rapidhash here, and I saw that you were using seahash in trunk.
I believe rapidhash comprehensively beats seahash in quality and speed on all platforms, especially for long string/byte hashing. It's fully portable and doesn't rely on any hardware acceleration.
I couldn't find any benchmarks in the repo, but hopefully this improves project build times for users?
Very happy to answer any questions. Cheers!