Improve parallelisation#60
Open
kloetzl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy 2026 all round!
I like the improvements in multi-threading, but as implemented there are issues with the output. On larger datasets the output will be jumbled as the prints may happen in arbitrary order. So we have to separate the computation, parallelize that and then use the main thread for the output. Unfortunately, this requires us to store a matrix of O(N^2). Use molten if that should be an issue.
The two sequence parameters in the distance function were marked as
restrict. That means we cannot pass in the same sequence to implicitly get zero. I fixed that by skipping the self-comparison.