Fix measurement unit overlap with abbreviation#34
Open
palomena wants to merge 4 commits intotsproisl:masterfrom
Open
Fix measurement unit overlap with abbreviation#34palomena wants to merge 4 commits intotsproisl:masterfrom
palomena wants to merge 4 commits intotsproisl:masterfrom
Conversation
Author
|
I see there are some issues with the tests now, i. e. sentences ending with a measurement unit such as "[...] km/h.". I'll think about a fix to that problem and will edit my PR accordingly. |
Owner
|
Yeah, this would break things like "Es sind noch ungefähr 5km." At a first glance this might turn out to be tricky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with overlapping tokens in tokenizer.py. The issue is that the tokenizer first splits on all measurement units and afterwards on abbreviations. However in the case of overlap between measurement units and abbreviations e.g. due to custom additions to the units.txt or abbreviations.txt, the abbreviation cannot be handled anymore.
Concrete example:
Conflicts between custom abbreviation for sentence references
S.and units(seconds).Similar conflicts may arise for all other units that may double as abbreviation and appear in the context of digits or numbers. Since no unit in units.txt has a dot
.as suffix, we can use a negative dot lookahead to differentiate between units and abbreviations and resolve such conflicts. This will break if units with a dot get added to the units file, but to my knowledge that scenario is unlikely (but should be documented somewhere).