Repository navigation
Conversation
TsuruAppReconciler and TsuruCronJobReconciler returned the NotFound error when the watched object was already gone, so every deleted app or CronJob (any CronJob in the cluster, tsuru or not) stayed in the workqueue retrying with backoff and logging errors until the operator restarted. Ignore NotFound like the other reconcilers do.
Author
|
Closing to keep the review queue light. Happy to reopen if it's useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deleting a tsuru app, or any CronJob in the cluster, leaves the request retrying forever: TsuruAppReconciler and TsuruCronJobReconciler return the NotFound error from Get, so the controller keeps requeueing it with backoff and logging errors.
What
Tested with
make test(new tests for both reconcilers).Fixes #13