Fix ADDON_ACTION_BLOCKED for MultiBarBottomLeft:SetFrameStrata in Midnight#1817
Open
lixard-wow wants to merge 3 commits intotukui-org:mainfrom
Open
Fix ADDON_ACTION_BLOCKED for MultiBarBottomLeft:SetFrameStrata in Midnight#1817lixard-wow wants to merge 3 commits intotukui-org:mainfrom
lixard-wow wants to merge 3 commits intotukui-org:mainfrom
Conversation
…night In Midnight (12.0), two patterns in DisableBlizzard() taint SettingsPanel, causing ADDON_ACTION_BLOCKED for MultiBarBottomLeft:SetFrameStrata() whenever the talent frame is closed. Root cause: When the talent frame closes, UIParentPanelManager calls HideUIPanel which invokes SetAttribute to start a secure execution context. SettingsPanel may be hidden as part of this chain, triggering its OnHide. ElvUI replaced OnHide via SetScript (tainting SettingsPanel) and directly replaced TransitionBackOpeningPanel (also tainting it), so ElvUI's tainted code runs inside the secure execution and blocks the subsequent MultiBarBottomLeft:SetFrameStrata() call. Fix: 1. SetScript -> HookScript for SettingsPanel OnHide. 2. Direct TransitionBackOpeningPanel replacement -> hooksecurefunc + clear opener.
…executerange In Midnight (12.0), EditMode's UpdateSystems runs inside secureexecuterange, calling BreakFromFrameManager -> SetParent on Blizzard unit frames. This triggers ElvUI's LockParent hooksecurefunc, which calls frame:SetParent(E.HiddenFrame). Calling SetParent from tainted code inside a secure execution blocks an internal protected C call (reported as UNKNOWN). Fix: defer the re-parent via C_Timer.After(0) to run on the next tick, outside the secureexecuterange. Added InCombatLockdown() guards for the combat case.
lixard-wow
force-pushed
the
fix/settings-panel-taint-midnight
branch
from
223d2a5 to
4811014
Compare
…reCalls Registering AddLinePreCall(LINETYPE_SELLPRICE, TT.AddMoneyInfo) placed a callback in InsecureLinePreCalls. TooltipDataHandler's ProcessLinePreCalls checks next(InsecureLinePreCalls) for every line in every tooltip, and when that table is non-empty it routes through the AttributeDelegate attribute-crossing path. For C_TooltipInfo.GetTraitEntry data (talent buttons) inside instances, that crossing taints the secret leftColor values, causing GameTooltip_AddColoredLine to throw 'attempt to index local color (a secret table value tainted by ElvUI)'. Fix: remove the AddLinePreCall registration so InsecureLinePreCalls stays empty, keeping the talent tooltip line processing on the clean path. The sell price reformatting is moved to a post-call scan inside GameTooltip_OnTooltipSetItem, which already runs via the InsecureTooltipPostCalls path (fires after ProcessLines so it cannot affect the color error).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Midnight (12.0), closing the talent frame produces:
This fires every time the talent frame is closed (2x per open/close cycle).
Root Cause
Two patterns in
DisableBlizzard()taintSettingsPanel, causing a protected call to fail inside a secure execution context:1.
SetScripton SettingsPanel.OnHide (line ~1323)SetScriptcompletely replaces the frame's handler with ElvUI addon code, taintingSettingsPanel. WhenUIParentPanelManagerclosesSettingsPanelas part of the talent frame'sHideUIPanelchain (inside aSetAttribute-triggered secure execution), ElvUI's taintedOnHideruns and poisons the execution context.2. Direct
TransitionBackOpeningPanelreplacement (line ~1337)Direct Lua table assignment replaces a Blizzard method with an ElvUI function, tainting the frame.
UIParentPanelManagercallsTransitionBackOpeningPanel()inside the same secure execution chain, running tainted ElvUI code, which then causesMultiBarBottomLeft:SetFrameStrata()to be blocked.Fix
1.
SetScript→HookScriptHookScriptappends ElvUI's handler after the original without replacing or tainting it.2. Direct replacement →
hooksecurefunc+ clear openerhooksecurefuncpreserves the untainted Blizzard implementation. Settingself.opener = nilin the hook prevents the game menu from reopening (the original intent of the replacement) without introducing taint into the secure execution path.Testing
ADDON_ACTION_BLOCKEDforSetFrameStratashould no longer fireSettingsPanel_OnHidebehavior (bindings save, micro buttons update) still works correctly