[pull] master from curl:master #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhat unexpectedly, switching autotools jobs to identical (non-unity, non-debug, same options) cmake ones, makes them complete 2x faster. Most of it comes from cmake building shared libcurl only, while autotools was using defaults and building both, in two separate passes. Thers is about a minute (per job) of gain due to other reasons. Before: MultiSSL: 10m30: https://github.com/curl/curl/actions/runs/20656775456/job/59311070197 H3: 9m14s: https://github.com/curl/curl/actions/runs/20656775456/job/59311070204 After: MultiSSL: 4m52s: https://github.com/curl/curl/actions/runs/20658343323/job/59315501903 H3: 4m7s: https://github.com/curl/curl/actions/runs/20658343323/job/59315501918 H3: 5m4s: https://github.com/curl/curl/actions/runs/20659294959/job/59318215987 (autotools shared only, for comparison, not merged) Also: - drop building examples with scan-build in the second (shorter) job. This offers no extra coverage over the long job that has both GnuTLS and OpenSSL. Saving an extra ~30s. Closes #20159
…h in 10m
To make CI turnaround time shorter, by cutting the longest running jobs.
After this patch all jobs should finish around 10-11 minutes. Down from
15-16 minutes before this patch.
Suggested-by: Stefan Eissing
The fuzzing workflow is now the slowest (with a 7-minute startup time
needed to build deps from source on each run), followed by macOS
and Windows torture tests (both split in two now). Without fuzzing, it's
under 10 minutes.
Notes:
- an extra cost with job-pairs is installing prereqs,
configuring/building curl and tests twice. GitHub doesn't support
making a matrix job a prereq for another workflow that may fix this:
https://github.com/orgs/community/discussions/42335
This overhead is significant on Windows: 11m20 -> 9m20 + 8m40
- job-pairs are annoying to maintain and keep in sync.
- splitting tests into halves is a manual process and needs to be
revisited from time to time. Possibly something to automate with
a runtests option, e.g. with `1 of 50%` and `2 of 50%`?
Also:
- split torture tests in two equal pieces, replacing the `FTP` + `!FTP`
split used earlier.
Related perf improvements from today:
- make scan-build 2x fast:
ff958fc #20159
- drop build-only Testi386 fuzz workflow (from curl), saving 9m per run:
curl/curl-fuzzer@0106023
curl/curl-fuzzer#236
Closes #20153
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )