React Native support by ospfranco · Pull Request #1423 · tursodatabase/libsql

ospfranco · 2024-05-27T18:39:19Z

Adds the necessary scripts to build the C bindings for iOS and Android which the in turn only need to be dropped into iOS/Android projects to be used via Obj-C++ or Android's JNI.

For my specific use case I use them in op-sqlite.

libsql-ffi/build.rs

haaawk · 2024-06-24T09:48:05Z

Some CI checks are failing @ospfranco

haaawk · 2024-06-24T09:49:18Z

bindings/c/Cargo.toml

 [dependencies]
 bytes = "1.5.0"
 lazy_static = "1.4.0"
-libsql = { path = "../../libsql", features = ["encryption"] }


This is not an acceptable change. Most of our projects that use C bindings depend on the encryption feature.

haaawk · 2024-06-24T09:49:52Z

bindings/c/Cargo.toml

 edition = "2021"

 [lib]
-crate-type = ["cdylib", "staticlib"]


Removing cdylib for all targets is probably not acceptable.

haaawk · 2024-06-24T09:50:56Z

bindings/c/Cargo.toml

 hyper-rustls = { version = "0.25", features = ["webpki-roots"]}
+
+[profile.release]
+strip = "symbols"


This is something we need to talk about. Removing symbols makes debugging really hard. @penberg @MarinPostma @LucioFranco do you have any opinion about this?

Tried this to reduce the size of the binary, Rust binaries are way to large for mobile targets. Currently with symbol stripping the binary sits at 60mbs, which is way too much.

Recently wrote more about this:

https://ospfranco.com/rust-reduce-binary-size/

I can remove it, but don't have the time to see how to apply stripping and lto optimization for conditional targets, did not find any documentation on how to do it.

Then maybe comment it out with a note that it should be uncommented for android/ios builds to reduce the size of the binary

It's already removed, I commented it out

haaawk · 2024-06-24T09:53:56Z

rust-toolchain.toml

 [toolchain]
 profile = "default"
 channel = "1.78.0"
+targets = ["x86_64-apple-ios", "aarch64-apple-ios", "aarch64-apple-ios-sim", "aarch64-linux-android", "armv7-linux-androideabi", "x86_64-linux-android", "i686-linux-android"]


Don't we need a desktop targets for linux and macos as well?

If you want, it makes it easier to set up cross compilation on new machines as you don't have to run the rustup install target ... commands but this is entirely optional

This force the installation of too many toolchains that are useless most of the time, and it just broke my installation by creating conflicts.

Feel free to remove it

How did it create conflicts? It seems pretty harmless except for using some disk space, no?

ospfranco · 2024-06-24T10:45:15Z

Thanks for taking a look, however, I'm currently swamped with work and next week I'm going on vacation for several months. Feel free to take over this PR and modify it as you see fit:

The changes on build.rs are reversible
Encryption seems to be compiling sqlcipher (?) via cmake, which also includes OpenSSL flags, the problem the compilation step is hard to integrate with Android (and that's why I had to disable it). Someone else that knows the internals of libsql should give it a try.
The rest seem trivial

After all is done and said, you only need to follow the guide I left you on notion to produce a static lib and run that against the opsqlite sample app. Once the emulator starts and everything is green you are ready to go.

P.S. if you do turn on encryption, it will require a modification to the bindings to send the encryption key from JS, so, open a PR when the time comes and I will take a look.

haaawk · 2024-06-25T10:42:58Z

Thanks for taking a look, however, I'm currently swamped with work and next week I'm going on vacation for several months. Feel free to take over this PR and modify it as you see fit:

I'm not sure I will have capacity to take this PR over. Could you please finish it to the state that's mergable. Right now multiple CI checks are failing for it so it is impossible to accept such work and integrate it into the repository.

The changes on build.rs are reversible

What does that mean? They are not needed? The changes that are required by Android and iOS need to be merged and if they are not compatible with other targets then they should be guarded with android or ios feature.

Encryption seems to be compiling sqlcipher (?) via cmake, which also includes OpenSSL flags, the problem the compilation step is hard to integrate with Android (and that's why I had to disable it). Someone else that knows the internals of libsql should give it a try.

It's ok to disable the encryption for Android and maybe iOS for now but it should be done only for that targets not for all targets which breaks them.

The rest seem trivial

After all is done and said, you only need to follow the guide I left you on notion to produce a static lib and run that against the opsqlite sample app. Once the emulator starts and everything is green you are ready to go.

Could you paste a link to that guide please? I haven't seen it yet.

P.S. if you do turn on encryption, it will require a modification to the bindings to send the encryption key from JS, so, open a PR when the time comes and I will take a look.

Add steps for Android PR comments

ospfranco · 2024-06-25T12:29:43Z

Leaving the guide to submitting updates to op-sqlite here for future reference:

https://ospfranco.notion.site/Libsql-4dbbf5793f654eccb9f5f68901224e97

ospfranco commented May 27, 2024

View reviewed changes

libsql-ffi/build.rs Show resolved Hide resolved

ospfranco commented May 27, 2024

View reviewed changes

libsql-ffi/build.rs Show resolved Hide resolved

ospfranco force-pushed the osp/react-native branch from 2c1adac to f79b193 Compare June 4, 2024 14:50

haaawk reviewed Jun 24, 2024

View reviewed changes

ospfranco force-pushed the osp/react-native branch from afa98b0 to 5bfa592 Compare June 25, 2024 12:21

iOS/Android Support

bb63914

Add steps for Android PR comments

ospfranco force-pushed the osp/react-native branch from 5bfa592 to bb63914 Compare June 25, 2024 12:23

haaawk approved these changes Jun 25, 2024

View reviewed changes

comment size optimization

8c1f718

haaawk approved these changes Jun 25, 2024

View reviewed changes

haaawk added this pull request to the merge queue Jun 25, 2024

Merged via the queue into tursodatabase:main with commit 30623f9 Jun 25, 2024

ospfranco deleted the osp/react-native branch June 26, 2024 11:58

jmatsushita mentioned this pull request Dec 13, 2024

[Request]: Use new libsql-c bindings and dynamic linking OP-Engineering/op-sqlite#203

Closed

This was referenced May 16, 2025

[Question]: libsql encryption support OP-Engineering/op-sqlite#224

Closed

Enable encryption for mobile targets #2070

Open

Conversation

ospfranco commented May 27, 2024

Uh oh!

Uh oh!

Uh oh!

haaawk commented Jun 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ospfranco commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haaawk commented Jun 25, 2024

Uh oh!

ospfranco commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ospfranco commented Jun 24, 2024 •

edited

Loading

ospfranco commented Jun 25, 2024 •

edited

Loading