Update modal docs#30325
Merged
Merged
Conversation
Member
|
Imo, this PR removes a little too much. I think people like it to just copy-paste the whole modal. |
Contributor
Author
|
I do not think so. The first snippet in the "Scrolling long content" section makes no sense. Also, the current snippets of the size options don't work (broken) already because there are no content in the |
Member
|
I'm in between personally; I see @ysds's and @MartijnCuppens's points. /CC @mdo to the rescue :P |
Member
|
FWIW i don't mind the cuts here |
MartijnCuppens
approved these changes
Mar 23, 2020
MartijnCuppens
left a comment
MartijnCuppens
left a comment
Member
There was a problem hiding this comment.
Fine by me, let's do this
XhmikosR
pushed a commit
that referenced
this pull request
Mar 25, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Mar 25, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Mar 28, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Mar 31, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Mar 31, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30055