Conversation
- Introduced `getNavigationMenuItemIconColors` utility to manage icon colors based on the theme. - Updated `CurrentWorkspaceMemberNavigationMenuItems` and `NavigationDrawerItemForObjectMetadataItem` to utilize the new icon color utility. - Refactored `NavigationMenuItemIcon` to include a styled background for icons, improving visual consistency. - Adjusted `NavigationDrawerItem` and `NavigationDrawerSubItem` to accept and apply background colors for icons. These changes improve the visual representation of navigation items and ensure consistent theming across the application.
- Added `IconColor` to the `useGetStandardObjectIcon` hook for improved icon color customization. - Simplified logic for determining icon background color based on the presence of `targetRecordId` and `viewId`. - Consolidated avatar rendering logic to reduce redundancy and improve readability. These changes enhance the visual consistency and flexibility of navigation menu items.
- Introduced the IS_NAVIGATION_MENU_ITEM_EDITING_ENABLED flag across the GraphQL schema and server-side enums. - Updated the workspace entity manager tests to include the new feature flag. - Enhanced the seed feature flags utility to support the new flag. These changes enable editing capabilities for navigation menu items, improving customization options.
- Introduced `useNavigationMenuEditModeActions` for managing edit mode actions, including entering and canceling edit mode. - Added `useNavigationMenuItemsDraftState` to handle draft state of navigation menu items, determining workspace items based on edit mode. - Created `isNavigationMenuInEditModeState` and `navigationMenuItemsDraftState` atoms for managing edit mode status and draft items. These additions enhance the functionality for editing navigation menu items, improving user experience and customization options.
- Added an `inverted` prop to `CancelButton`, allowing for a tertiary button style. - Updated `SaveButton` to support an `inverted` prop, changing its appearance based on the prop value. - Modified `SaveAndCancelButtons` to pass the `inverted` prop to both buttons, ensuring consistent styling. These changes improve the visual flexibility of the buttons in the settings module, enhancing user experience.
- Introduced `CommandMenuNavigationMenuItemEditPage` for editing navigation menu items. - Updated `COMMAND_MENU_PAGES_CONFIG` to include the new edit page. - Added state management for selected navigation menu item in edit mode. - Enhanced `WorkspaceNavigationMenuItems` to support opening the edit page and handling edit mode interactions. These changes improve the user experience by allowing direct editing of navigation menu items within the command menu.
- Added support for handling active item clicks in the `WorkspaceNavigationMenuItems` component, allowing users to interact with items even when not in edit mode. - Introduced a new styled container for right icons to improve layout and spacing. - Updated `NavigationDrawerItemForObjectMetadataItem` and `NavigationDrawerSectionForObjectMetadataItems` components to accommodate the new click handling logic, enhancing user experience and interaction consistency. These changes improve the functionality and usability of the navigation menu, making it more intuitive for users.
…ent Structure - Removed unused imports and state management related to views and context store, streamlining the component. - Simplified the rendering logic by eliminating the collapsible container and directly rendering the `NavigationDrawerItem`. - This refactor enhances readability and maintainability of the code while preserving existing functionality.
- Introduced a new 'workflowsFolder' item in the standard navigation menu, enhancing organization of workflow-related views. - Added new entries for 'workflowsFolderAllWorkflows', 'workflowsFolderAllWorkflowRuns', and 'workflowsFolderAllWorkflowVersions' to improve navigation and access to workflow data. - Created utility functions for generating flat metadata for folder items, streamlining the integration of new navigation items. - Updated existing view and view field utilities to include support for workflow versions, ensuring comprehensive coverage in the navigation structure. These changes enhance the user experience by providing a clearer and more structured navigation menu for workflows and their associated views.
…on Items - Updated the navigation menu item components to utilize user-specific navigation items, enhancing the organization of workspace-related views. - Introduced a new `WorkspaceNavigationMenuItemsFolder` component to manage folder items within the workspace navigation. - Refactored hooks to separate workspace and user navigation items, improving data handling and clarity. - Added utility functions to identify navigation menu item folders, streamlining the integration of folder items in the navigation structure. These changes enhance the user experience by providing a more structured and intuitive navigation menu for workspace items.
…ogic - Replaced the `selectedWorkspaceObjectMetadataItemIdInEditModeState` with `selectedNavigationMenuItemInEditModeState` to streamline state management for navigation menu items. - Updated components to utilize the new state, enhancing clarity and consistency across the navigation menu. - Refactored hooks and component logic to improve handling of navigation menu item selection and editing, ensuring a more intuitive user experience. - Introduced new utility functions and styled components to support the updated navigation structure. These changes enhance the overall functionality and maintainability of the navigation menu system.
- Adjusted the width calculation in the `NavigationDrawerItem` component to account for additional spacing when right options are present. - Improved the responsiveness of the navigation drawer by refining the width logic for both expanded and collapsed states. These changes enhance the visual consistency and usability of the navigation drawer items.
…ctionality - Introduced the ability to move navigation menu items up and down within the command menu, improving item organization. - Added a remove option to delete selected navigation menu items, streamlining item management. - Refactored the `CommandMenuNavigationMenuItemEditPage` component to utilize new hooks for item manipulation and state management. - Updated related components and hooks to ensure consistent handling of navigation menu items. These changes enhance the user experience by providing more control over navigation menu item arrangements and management.
…ture - Introduced the `CommandMenuNewSidebarItemPage` component to facilitate the addition of new items to the navigation menu. - Updated the `CommandMenuPagesConfig` to include the new sidebar item page, enhancing navigation options. - Implemented hooks for adding objects and records to the navigation menu draft, improving item management. - Refactored the `NavigationMenuEditModeBar` to support saving drafts and handling loading states, streamlining the editing process. These changes enhance the command menu's functionality, providing users with more options for managing navigation items effectively.
…enuItemsDraft hook - Eliminated the assignment of targetObjectMetadataId to undefined when viewId is defined, streamlining the input handling logic. - This change improves the clarity and efficiency of the hook's functionality, ensuring only relevant data is processed.
- Added support for system objects in the `CommandMenuNewSidebarItemPage`, allowing users to filter and select system-related items. - Introduced new state management for system object search input and updated the back navigation logic for improved user experience. - Refactored object metadata filtering to include system objects, enhancing the overall functionality of the command menu. - Improved search functionality by implementing a dedicated search input for objects, streamlining the selection process. These changes enhance the command menu's capabilities, providing users with more comprehensive options for managing navigation items.
- Integrated functionality for adding views to the navigation menu draft within the `CommandMenuNewSidebarItemPage`. - Introduced a new hook, `useAddViewToNavigationMenuDraft`, to manage view additions effectively. - Updated state management to accommodate view selection and search inputs, enhancing user interaction. - Refactored related components and utilities to support view handling, improving overall command menu functionality. These changes enhance the command menu's capabilities, allowing users to manage views alongside other navigation items seamlessly.
- Added a new `noResultsText` prop to the `CommandMenuList` component, allowing for customizable no results messages. - Updated the `CommandMenuNewSidebarItemPage` to utilize the new prop, providing context-specific messages based on user input. - Refactored the logic for displaying results to improve clarity and user experience when no views are found. These changes enhance the flexibility of the command menu, improving user feedback during navigation item searches.
- Updated the back navigation logic in the `CommandMenuNewSidebarItemPage` to handle system object selections more effectively. - Introduced a check for system object metadata to set the appropriate navigation option when returning to the view object list. - Improved user experience by ensuring the correct state is maintained during navigation actions. These changes enhance the functionality of the command menu, providing users with a more intuitive navigation experience when dealing with system objects.
…nu Functionality - Consolidated multiple hooks for adding items to the navigation menu draft into a single `useAddToNavigationMenuDraft` hook, streamlining the process for adding objects, views, and records. - Removed outdated hooks `useAddObjectToNavigationMenuDraft`, `useAddViewToNavigationMenuDraft`, and refactored related components to utilize the new consolidated hook. - Introduced `useUpdateNavigationMenuItemsDraft` hook to manage updates to navigation menu items in draft state, enhancing item editing capabilities. - Enhanced the `CommandMenuNavigationMenuItemEditPage` with improved state management and additional functionality for object selection and navigation item manipulation. - Updated the `useNavigationMenuItemMoveRemove` hook to include a new `moveToFolder` function, allowing for better organization of navigation items. These changes improve the overall efficiency and usability of the command menu, providing users with a more cohesive experience when managing navigation items.
- Updated the `CommandMenuNavigationMenuItemEditPage` to handle empty folder states more gracefully, displaying a custom message when no folders are available. - Refactored the logic for generating selectable item IDs to include a fallback for empty states. - Improved the sorting logic in `sortNavigationMenuItems` to correctly handle index views and associated metadata, ensuring accurate display of labels and icons. - Adjusted test cases to reflect changes in object naming conventions and ensure consistency in expected outcomes. These changes improve the user experience by providing clearer feedback and more accurate representations of navigation items in the command menu.
- Updated the `WorkspaceNavigationMenuItemsFolder` component to conditionally render secondary labels based on the view key, improving clarity in navigation item representation. - Simplified the logic in `sortNavigationMenuItems` to ensure consistent handling of object names, enhancing the accuracy of displayed labels. These changes enhance the user experience by providing clearer navigation item details and improving the overall sorting logic.
- Introduced `CommandMenuSelectObjectForViewEditMenuItem` component to facilitate object selection for view editing. - Enhanced state management in `CommandMenuNavigationMenuItemEditPage` to track selected object metadata for view editing. - Updated logic to filter and sort objects based on their association with views, improving the user experience during object selection. - Adjusted rendering logic to differentiate between object and view editing modes, ensuring clarity in user interactions. These changes enhance the command menu's functionality, providing users with a more intuitive experience when managing object views.
…tadata items - Added a `secondaryLabel` prop to `NavigationDrawerItemForObjectMetadataItem` component. - The `secondaryLabel` is conditionally set based on whether the item is a record or a view with a custom name, improving the clarity of displayed metadata. This change enhances the user interface by providing additional context for object metadata items in the navigation drawer.
- Added `useCommandMenu` hook to manage command menu interactions. - Updated save draft logic to close the command menu upon successful save, enhancing user experience during navigation menu edits. This change improves the responsiveness of the navigation menu editing process by ensuring the command menu closes automatically after saving changes.
…eInfo - Introduced `CommandMenuFolderInfo` component to manage folder-specific interactions within the command menu. - Updated `CommandMenuPageInfo` to conditionally render `CommandMenuFolderInfo` when editing a navigation menu item in folder mode. - Enhanced folder management capabilities by adding folder creation and editing functionalities in the command menu. These changes improve the user experience by providing a dedicated interface for folder management within the command menu, streamlining navigation and editing processes.
Eliminated the IS_NAVIGATION_MENU_ITEM_EDITING_ENABLED feature flag from the seedFeatureFlags utility, streamlining the code and removing redundancy.
- Enhanced the formatting of test cases in recordIdentifierToObjectRecordIdentifier, sortNavigationMenuItems, and validateAndExtractWorkspaceFolderId tests for better clarity. - Added comments to the CommandMenuNewSidebarItemViewPickerSubView component to clarify prop spreading, improving maintainability and understanding of the code.
Deleted outdated test files for getIconBackgroundColorForPayload, getNavigationMenuItemIconColors, and isWorkspaceDroppableId functions to streamline the test suite and eliminate redundancy. These tests are no longer necessary due to recent refactoring and updates in the utility functions.
Devessier
approved these changes
Feb 11, 2026
Contributor
Devessier
left a comment
Devessier
left a comment
There was a problem hiding this comment.
Okay for me! Great job 👍
abdulrahmancodes
force-pushed
the
feat/navbar-customization
branch
from
4d9b2d1 to
7391b7b
Compare
- Added new scalar type `Upload` to support file uploads. - Introduced multiple input types for creating and managing various entities, including `ActivateWorkspaceInput`, `CreateAgentInput`, and `CreateApiKeyInput`. - Expanded the schema with new enums such as `AllMetadataName` and `AnalyticsType` for better categorization of metadata and analytics events. - Added new mutation inputs for workflow management, including `CreateWorkflowVersionEdgeInput` and `DeleteWorkflowVersionStepInput`. - Implemented additional filtering capabilities with `DateTimeFilter` to enhance query flexibility. These changes improve the overall functionality and usability of the GraphQL API, enabling more robust interactions with the backend.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
e2e tests don't pass. Checking why. |
Contributor
|
e2e tests should pass now |
|
Hey @Devessier! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
1 similar comment
|
Hey @Devessier! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Contributor
LogDetails |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
Addresses review comments from the [first navbar customization PR](#17728) --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Devessier <baptiste@devessier.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.