WebViewController: Actually display back/forward/share buttons#233
Open
diktomat wants to merge 2 commits intotwostraws:mainfrom
Open
WebViewController: Actually display back/forward/share buttons#233diktomat wants to merge 2 commits intotwostraws:mainfrom
diktomat wants to merge 2 commits intotwostraws:mainfrom
Conversation
Owner
|
I'm only now managing to get around to this – sorry! I think this might have been resolved with another PR. |
|
Is this already in release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon fixing #232, I discovered it actually was all already in there, so all I did was display the buttons. If there was a reason for not displaying them, please tell me, so I can try to do it right.
Works fine for me in simulator, and no new failing tests or linting errors due to my commit.