Skip to content

Remove GraalVM from CI matrix#4153

Merged
djspiewak merged 3 commits intotypelevel:series/3.5.xfrom
mzuehlke:series-3.5x/graalvm21
Oct 25, 2024
Merged

Remove GraalVM from CI matrix#4153
djspiewak merged 3 commits intotypelevel:series/3.5.xfrom
mzuehlke:series-3.5x/graalvm21

Conversation

@mzuehlke
Copy link
Contributor

GraalVM is no longer available under the free license: https://github.com/graalvm/setup-graalvm#notes-on-oracle-graalvm-for-jdk-17

sbt-typelevel already did the same: typelevel/sbt-typelevel#763

GraalVM is no longer available under the free license: https://github.com/graalvm/setup-graalvm#notes-on-oracle-graalvm-for-jdk-17

sbt-typelevel already did the same: typelevel/sbt-typelevel#763
@mzuehlke
Copy link
Contributor Author

I guess the Scala versions in this branch are way too old

@armanbilge
Copy link
Member

Oh darn, actually we can't use GraalVM 21 here at all, because this branch is pinned to Scala 3.2 and we can't do anything about that.

@mzuehlke
Copy link
Contributor Author

So dropping GraalVM from this branch seems to be the only option, or follow the not recommended path https://github.com/graalvm/setup-graalvm#notes-on-oracle-graalvm-for-jdk-17 and use exactly java-version: '17.0.12'

@armanbilge
Copy link
Member

use exactly java-version: '17.0.12'

Oh, good idea. Let's do that. This branch just needs to limp a little longer.

@mzuehlke
Copy link
Contributor Author

The way sbt-typelevel uses the version number leads to an invalid workflow file 😢

Invalid workflow file: .github/workflows/ci.yml#L206
The workflow is not valid. .github/workflows/ci.yml (Line: 206, Col: 20): Unexpected symbol: '0.12.outputs.jdkFile'. Located at position 32 within expression: steps.download-java-graalvm-17.0.12.outputs.jdkFile .github/workflows/ci.yml (Line: 404, Col: 20): Unexpected symbol: '0.12.outputs.jdkFile'. Located at position 32 within expression: steps.download-java-graalvm-17.0.12.outputs.jdkFile

@mzuehlke
Copy link
Contributor Author

I would propose to remove GraalVM from the build matrix then.

@armanbilge
Copy link
Member

The way sbt-typelevel uses the version number leads to an invalid workflow file 😢

Crap. We should fix this bug in sbt-tl.

That probably won't help us here though. We might just have to remove GraalVM.

@djspiewak
Copy link
Member

Removing GraalVM from 3.5 feels like the right short-term strategy. We really need to get 3.6 out the door.

@djspiewak
Copy link
Member

Note to self: when we do our next 3.5 release, we need to make sure to revert this commit specifically.

@djspiewak djspiewak merged commit d241856 into typelevel:series/3.5.x Oct 25, 2024
@mzuehlke mzuehlke deleted the series-3.5x/graalvm21 branch October 25, 2024 20:49
@mzuehlke
Copy link
Contributor Author

Note to self: when we do our next 3.5 release, we need to make sure to revert this commit specifically.

What do you want to revert ? The problem is that you can no longer download GraalVM 17 without a paid license.
Specifying the latest patch version that is still available isn't working with sbt-typelevel-github-action.
And excape would be to "fix the GHA ci.yml by hand and disable the usage of githubWorkflowCheck.

@armanbilge armanbilge changed the title Update GraalVM from 17 to 21 Remove GraalVM from CI matrix Oct 27, 2024
Comment on lines -197 to -202
WorkflowStep.Sbt(
List("graalVMExample/nativeImage", "graalVMExample/nativeImageRun"),
name = Some("Test GraalVM Native Image"),
cond = Some(
s"matrix.scala == '$Scala213' && matrix.java == '${GraalVM.render}' && matrix.os == '$PrimaryOS'")
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you want to revert ?

We should have restored this in series/3.6.x branch 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants