Support custom matrices for artifact upload/download#98
Merged
armanbilge merged 4 commits intotypelevel:series/0.4from Jan 26, 2022
Merged
Conversation
This was referenced Jan 24, 2022
Member
|
Regarding the choice of Set, does the order of keys matter, or do they just need to be in the same arbitrary order in order to generate a unique ID? |
Member
Author
|
Just a consistent (but otherwise arbitrary) ordering. Edit: sorry, I'm confusing with the |
rossabaker
approved these changes
Jan 26, 2022
Member
rossabaker
left a comment
There was a problem hiding this comment.
Okay, if consistent-but-arbitrary is the goal, and that makes sense, then I think it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74. In doing so, I hope it fixes #81 as well.
This is a fairly complex change, consisting of the following:
$os-$scala-$java. If the matrix is crossed on other things, such as JVM/JS, this leads to artifacts with duplicate ids being uploaded. I suspect this may be what causes the failures we've been observing in CI.$os-$java-$scala-$key1-$key2etc. This assumes that sensible value names are being used in the matrix (idk what the rules are for artifact upload names).githubWorkflowArtifactDownloadExtraKeyssetting (please help bikeshed name).Set[String]of keys of the first kind above (i.e., for which we must download artifacts for each value). We use it to add the keyproject(with valuesrootJVM,rootJSand/orrootNative) when setting up the platform cross in the matrix.These changes are fairly internal but possibly deserve a minor version bump. In any case, before releasing I will test the snapshot on some relevant projects.